[PATCH] D115981: [InstrProf] Mark counters as used in debug correlation mode

Ellis Hoag via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 20 13:19:11 PST 2021


ellis planned changes to this revision.
ellis added a comment.

In D115981#3201096 <https://reviews.llvm.org/D115981#3201096>, @kyulee wrote:

> My understanding is that the counter symbol is referenced by a text/code. So it's naturally retained as long as the function is kept.
> Is there any specific case this needs to be explicitly used?

Ah thank you. I've since ran some experiments and found that after https://reviews.llvm.org/D116051 the number of profiled functions is about what we expect without this patch. However, I'm working on another patch that only profiles function entry coverage and this code change is needed in that case. I'll do more investigation and follow up more.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115981/new/

https://reviews.llvm.org/D115981



More information about the llvm-commits mailing list