[PATCH] D115996: [AMDGPU] Don't remove VGPR to AGPR dead spills from frame info

Christudasan Devadasan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 20 10:39:05 PST 2021


cdevadas added a comment.

In D115996#3203105 <https://reviews.llvm.org/D115996#3203105>, @rampitec wrote:

> In D115996#3202932 <https://reviews.llvm.org/D115996#3202932>, @arsenm wrote:
>
>> Can we rip out this special "spill" handling since D109301 <https://reviews.llvm.org/D109301> @cdevadas
>
> I has unsolved problem with partial tuple spill. There is no partial copy.

I'm not sure how we are going to handle this partial copy differently.
The equivalent for partial-copy during regalloc would be possible only if the `tryInstructionSplit` inserts partial copy followed by the `InlineSpiller` handling the leftover tuple spills.
Currently, the former doesn't handle partial copy and the latter doesn't insert subrange tuple spills/restores.  
Even if they are equipped to handle partial copy and spill, how do these independent functions communicate each other the exact tuple subrange that the other suppose to handle?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115996/new/

https://reviews.llvm.org/D115996



More information about the llvm-commits mailing list