[PATCH] D116032: Avoid useless AttrBuilder conversion

[serge via Phabricator via llvm-commits]

serge-sans-paille added inline comments.


================
Comment at: llvm/lib/IR/Attributes.cpp:1286
+  AttrBuilder Merged(getAttributes(Index));
+  Merged.merge(AS);
+  return setAttributesAtIndex(C, Index, AttributeSet::get(C, Merged));
----------------
@nikic As can be seen here, we're not converting AS to an AttrBuilder, directly calling the merge from an AttributeSet


================
Comment at: llvm/lib/IR/Attributes.cpp:1793
+AttrBuilder &AttrBuilder::merge(AttributeSet AS) {
+  for(Attribute A : AS)
+    addAttribute(A);
----------------
This merge doesn't require a temporary AttrBuilder


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116032/new/

https://reviews.llvm.org/D116032