[PATCH] D114652: [AMDGPU] Move call clobbered return address registers s[30:31] to callee saved range

[Venkata Ramanaiah Nalamothu via Phabricator via llvm-commits]

RamNalamothu marked an inline comment as done.
RamNalamothu added a comment.

I think I have addressed all the outstanding feedback. Is this good to go now?



================
Comment at: llvm/lib/Target/AMDGPU/SIInstrInfo.cpp:2081
+        BuildMI(MBB, MI, DL, get(AMDGPU::S_SETPC_B64_return))
+            .addReg(TRI->getReturnAddressReg(*MF), RegState::Undef);
+
----------------
arsenm wrote:
> If we're going to just hardcode this to s[30:31], probably should do away with getReturnAddressReg
I believe using `getReturnAddressReg()` doesn't hurt and any future updates can be made easily without changing all the places.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114652/new/

https://reviews.llvm.org/D114652