[PATCH] D115993: [ELF] Optimize RelocationSection<ELFT>::writeTo

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

No objections from me. It may be worth getting some figures from the lld speed test (https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20171030/498843.html) as well, although I expect they won't show regressions.

Will be out of office for the next couple of weeks so may be a bit slow to respond. I'm happy for others to comment/approve.



================
Comment at: lld/ELF/SyntheticSections.h:480
+  Symbol *sym;
+  const OutputSection *outputSec = nullptr;
+  const InputSectionBase *inputSec;
----------------
Just thinking about making the enum size uint8_t Not entirely sure it will make a lot of difference in this case, but you may want to reorder some of the fields so that they minimise padding between items. For example addend before r_sym. Kind may also benefit from being last. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115993/new/

https://reviews.llvm.org/D115993