[PATCH] D115278: Check subrange liveness at rematerialization

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/CodeGen/LiveRangeEdit.cpp:146-148
+        LM &= ~SR.LaneMask;
+        if (LM.none())
+          break;
----------------
arsenm wrote:
> rampitec wrote:
> > arsenm wrote:
> > > This isn't required?
> > This is early exit. No need to continue iterating over the rest of the subranges if we have already checked all lanes we need. In case of wide register tuples this shall be faster.
> Probably should comment this is just for early exit (I'm also skeptical this helps anything)
We have pretty wide tuples so the loop may have to process up to 32 subranges.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115278/new/

https://reviews.llvm.org/D115278