[PATCH] D115278: Check subrange liveness at rematerialization

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 13 09:35:55 PST 2021


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/CodeGen/LiveRangeEdit.cpp:146-148
+        LM &= ~SR.LaneMask;
+        if (LM.none())
+          break;
----------------
rampitec wrote:
> arsenm wrote:
> > This isn't required?
> This is early exit. No need to continue iterating over the rest of the subranges if we have already checked all lanes we need. In case of wide register tuples this shall be faster.
Probably should comment this is just for early exit (I'm also skeptical this helps anything)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115278/new/

https://reviews.llvm.org/D115278



More information about the llvm-commits mailing list