[PATCH] D115921: [RISCV] Refactor the RISCV ISA extension info and target features to support multiple extension version

Zixuan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 19 18:33:00 PST 2021


zixuan-wu added a comment.

In D115921#3201346 <https://reviews.llvm.org/D115921#3201346>, @luismarques wrote:

>> enable 'm' extension with passing mattr=+m After this patch, it would be -mattr=+m2p0.
>
> It's not obvious to me that support for extension versions should mean or has to mean that we always explicitly specify the version. Why can't we keep supporting the option `mattr=+m`, which would be mapped to `mattr=+m,+m2p0`, or whatever the current default `m` version happens to be?

OK. I think default version mattr is acceptable. And then testcases change would be clean and simple.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115921/new/

https://reviews.llvm.org/D115921



More information about the llvm-commits mailing list