[PATCH] D115808: [DAGCombiner] Avoid combining adjacent stores at -O0 to improve debug experience

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D115808#3201773 <https://reviews.llvm.org/D115808#3201773>, @xgupta wrote:

> I will commit as it seems not a big change. and all comments are addressed.

This goes against the LLVM Code-Review Policy and Practices:

> Code review can be an iterative process, which continues until the patch is ready to be committed. Specifically, once a patch is sent out for review, it needs an explicit approval before it is committed. Do not assume silent approval, or solicit objections to a patch with a deadline.



- https://llvm.org/docs/CodeReview.html#code-review-workflow

I only commented on the test case to make sure you didn't make a mess of llvm/test/CodeGen/RISCV. I don't agree with the DAGCombiner change itself, which may not surprise you, as it's just trying to patch over a fundamental issue (or non-issue) with SelectionDAG's current implementation, so my lack of commenting on that was not approval, just "I don't feel strongly enough to block it, and will let someone else decide on whether it's a worthwhile change".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115808/new/

https://reviews.llvm.org/D115808