[PATCH] D115992: [AA] Handle callbr instructions in alias analysis.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 18 08:58:52 PST 2021


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/AliasAnalysis.cpp:698-703
   case Instruction::Call:
     return getModRefInfo((const CallInst *)I, Loc, AAQIP);
+  case Instruction::CallBr:
+    return getModRefInfo((const CallBrInst *)I, Loc, AAQIP);
   case Instruction::Invoke:
     return getModRefInfo((const InvokeInst *)I, Loc, AAQIP);
----------------
As an optional suggestion, I think this would make it clearer which overload gets actually called.


================
Comment at: llvm/test/Analysis/BasicAA/pr52735.ll:14
+
+; CHECK-DAG: MayAlias: i32* %v, void (i32*, i8*)* asm "movl $$1, $0", "=*m,X,~{dirflag},~{fpsr},~{flags}"
+
----------------
Just CHECK suffices here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115992/new/

https://reviews.llvm.org/D115992



More information about the llvm-commits mailing list