[PATCH] D115973: [llvm-profgen] Support symbol loading for debug fission

[Alexander Yermolovich via Phabricator via llvm-commits]

ayermolo added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:674
+    if (llvm::Optional<uint64_t> DWOId = DwarfUnit->getDWOId())
+      continue;
+    loadSymbolsFromDWARFUnit(DwarfUnit);
----------------
Right now it will always use info from DWO sections, even if -fsplit-dwarf-inlining is set. I wonder if it's worth checking that if children exist use them. I think with split dwarf enabled -fsplit-dwarf-inlining is only option that will add children to Skeleton CU.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:690
+               << " was not retrieved and won't be updated. Please check "
+                  "relative path.\n";
         continue;
----------------
The path can be either relative or absolute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115973/new/

https://reviews.llvm.org/D115973