[PATCH] D115948: [llvm-profgen] Support to load debug info from a second binary

[Lei Wang via Phabricator via llvm-commits]

wlei added inline comments.


================
Comment at: llvm/test/tools/llvm-profgen/inline-cs-pseudoprobe.test:10-13
+; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/inline-cs-pseudoprobe.perfscript --binary=%S/Inputs/inline-cs-pseudoprobe.perfbin --debug-binary=%S/Inputs/inline-cs-pseudoprobe.dbg --output=%t --skip-symbolization --profile-summary-cold-count=0 --use-offset=0
+; RUN: FileCheck %s --input-file %t --check-prefix=CHECK-UNWINDER
+; RUN: llvm-profgen --format=text --perfscript=%S/Inputs/inline-cs-pseudoprobe.perfscript --binary=%S/Inputs/inline-cs-pseudoprobe.perfbin --debug-binary=%S/Inputs/inline-cs-pseudoprobe.dbg --output=%t --profile-summary-cold-count=0 --csspgo-preinliner=0
+; RUN: FileCheck %s --input-file %t
----------------
wenlei wrote:
> Let's use a dedicated/targeted test case for this scenario, instead of making existing test more complicated. 
Separated this part into a new test.


================
Comment at: llvm/test/tools/llvm-profgen/inline-noprobe2.test:112
 ; clang -O3 -g -fno-optimize-sibling-calls -fdebug-info-for-profiling qsort.c -o a.out
+; objcopy --only-keep-debug inline-noprobe2.perfbin inline-noprobe2.dbg
 #include <stdio.h>
----------------
hoy wrote:
> We should be able to use llvm-objcopy in the test, so the existing test binary can be reused and with an extra test step running llvm-objcopy.
Good point! Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115948/new/

https://reviews.llvm.org/D115948