[PATCH] D115859: [LoongArch 2/n] Add ELF machine flag and relocs for upcoming LoongArch target

Fri Dec 17 19:46:21 PST 2021

SixWeining added a comment.

In D115859#3199357 <https://reviews.llvm.org/D115859#3199357>, @jhenderson wrote:

> Two nits. Otherwise looks good. Your comment references llvm-objdump, but there's nothing testing llvm-objdump here. I imagine it's just a case of "it just works", due to the `Object` library changes?
>
> I haven't checked that the LOONGARCH definitions match up with any official spec. Do you have anything you could cite for these values i.e. ELF generic-abi mailing list for the EM value, and some psABI doc for the relocations?
>
> Not that I think this particular change needs it, but has there been any particular buy-in from the community for integrating this architecture at all? (In this case, I don't think it's necessary, but for wider changes, it probably is).
>
> Please note that I won't be online until the 4th of January, after today's work, so may be slow to respond to anything.

Thanks @jhenderson and I have updated this revision to address your comments.
It is worth mentioning that this change is based on the LoongArch ELF ABI: https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html which has been upstreamed to binutils.
And this is the RFC <https://lists.llvm.org/pipermail/llvm-dev/2021-December/154371.html> proposing LoongArch to LLVM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115859/new/

https://reviews.llvm.org/D115859