[PATCH] D115852: Passthrough LLVM_USE_LLD LLVM_USE_LINKER into runtimes

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added a comment.

This breaks our bot right now, I'm not sure how/why, maybe our CMake invocation isn't correct? It's not obvious to me though...

Here is what I  see in the log:

  cmake -G Ninja ${src_dir}/llvm -DLLVM_TARGETS_TO_BUILD="X86;NVPTX;AMDGPU" -DLLVM_ENABLE_PROJECTS="lld;clang;mlir" -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=Off -DLIBCXX_CXX_ABI=default -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi"  -DLLVM_ENABLE_LLD=ON  -DLLVM_DISTRIBUTION_COMPONENTS="clang;runtimes" -DLLVM_CCACHE_BUILD=ON
  ninja distribution

But then later in the process:

  [3938/4157] Performing configure step for 'runtimes'
  -- The C compiler identification is Clang 14.0.0
  -- The CXX compiler identification is Clang 14.0.0
  -- The ASM compiler identification is Clang
  -- Found assembler: /tmp/ci-jSvVzRPAaN/./bin/clang
  -- Detecting C compiler ABI info
  -- Detecting C compiler ABI info - done
  -- Check for working C compiler: /tmp/ci-jSvVzRPAaN/./bin/clang - skipped
  -- Detecting C compile features
  -- Detecting C compile features - done
  -- Detecting CXX compiler ABI info
  -- Detecting CXX compiler ABI info - done
  -- Check for working CXX compiler: /tmp/ci-jSvVzRPAaN/./bin/clang++ - skipped
  -- Detecting CXX compile features
  -- Detecting CXX compile features - done
  -- Performing Test Terminfo_LINKABLE
  -- Performing Test Terminfo_LINKABLE - Success
  -- Found Terminfo: /usr/lib/x86_64-linux-gnu/libtinfo.so
  -- Found ZLIB: /usr/lib/x86_64-linux-gnu/libz.so (found version "1.2.11")
  -- Performing Test LLVM_RUNTIMES_LINKING_WORKS
  -- Performing Test LLVM_RUNTIMES_LINKING_WORKS - Success
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDLIBXX_FLAG
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDLIBXX_FLAG - Success
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDINCXX_FLAG
  -- Performing Test LLVM_RUNTIMES_SUPPORT_NOSTDINCXX_FLAG - Success
  -- Linker detection: LLD
  CMake Error at /var/lib/buildkite-agent/builds/buildkite-588bd64db9-m924d-1/mlir/mlir-core/llvm/cmake/modules/HandleLLVMOptions.cmake:280 (message):
    LLVM_ENABLE_LLD and LLVM_USE_LINKER can't be set at the same time
  Call Stack (most recent call first):
    CMakeLists.txt:125 (include)
   
  -- Configuring incomplete, errors occurred!
  See also "/tmp/ci-jSvVzRPAaN/runtimes/runtimes-bins/CMakeFiles/CMakeOutput.log".
  See also "/tmp/ci-jSvVzRPAaN/runtimes/runtimes-bins/CMakeFiles/CMakeError.log".
  [3951/4157] Linking CXX static library lib/libMLIRTestReducer.a
  FAILED: runtimes/runtimes-stamps/runtimes-configure /tmp/ci-jSvVzRPAaN/runtimes/runtimes-stamps/runtimes-configure
  cd /tmp/ci-jSvVzRPAaN/runtimes/runtimes-bins && /usr/bin/cmake -DCMAKE_C_COMPILER=/tmp/ci-jSvVzRPAaN/./bin/clang -DCMAKE_CXX_COMPILER=/tmp/ci-jSvVzRPAaN/./bin/clang++ -DCMAKE_ASM_COMPILER=/tmp/ci-jSvVzRPAaN/./bin/clang -DCMAKE_LINKER=/tmp/ci-jSvVzRPAaN/./bin/ld.lld -DCMAKE_AR=/tmp/ci-jSvVzRPAaN/./bin/llvm-ar -DCMAKE_RANLIB=/tmp/ci-jSvVzRPAaN/./bin/llvm-ranlib -DCMAKE_NM=/tmp/ci-jSvVzRPAaN/./bin/llvm-nm -DCMAKE_OBJDUMP=/tmp/ci-jSvVzRPAaN/./bin/llvm-objdump -DCMAKE_OBJCOPY=/tmp/ci-jSvVzRPAaN/./bin/llvm-objcopy -DCMAKE_STRIP=/tmp/ci-jSvVzRPAaN/./bin/llvm-strip -DCMAKE_READELF=/tmp/ci-jSvVzRPAaN/./bin/llvm-readelf -DCMAKE_C_COMPILER_TARGET=x86_64-unknown-linux-gnu -DCMAKE_CXX_COMPILER_TARGET=x86_64-unknown-linux-gnu -DCMAKE_ASM_COMPILER_TARGET=x86_64-unknown-linux-gnu -DCMAKE_INSTALL_PREFIX=/usr/local -DLLVM_BINARY_DIR=/tmp/ci-jSvVzRPAaN -DLLVM_CONFIG_PATH=/tmp/ci-jSvVzRPAaN/bin/llvm-config -DLLVM_ENABLE_WERROR=OFF -DLLVM_HOST_TRIPLE=x86_64-unknown-linux-gnu -DLLVM_HAVE_LINK_VERSION_SCRIPT=1 -DLLVM_USE_RELATIVE_PATHS_IN_DEBUG_INFO=OFF -DLLVM_USE_RELATIVE_PATHS_IN_FILES=OFF -DLLVM_LIT_ARGS=-sv -DLLVM_SOURCE_PREFIX= -DPACKAGE_VERSION=14.0.0git -DCMAKE_BUILD_TYPE=Release -DCMAKE_MAKE_PROGRAM=/usr/bin/ninja -DCMAKE_EXPORT_COMPILE_COMMANDS=1 -DCOMPILER_RT_BUILD_BUILTINS=Off -DLLVM_INCLUDE_TESTS=ON -DLLVM_DEFAULT_TARGET_TRIPLE=x86_64-unknown-linux-gnu -DLLVM_ENABLE_PROJECTS_USED=ON -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON -DLLVM_BUILD_TOOLS=ON -DCMAKE_C_COMPILER_WORKS=ON -DCMAKE_CXX_COMPILER_WORKS=ON -DCMAKE_ASM_COMPILER_WORKS=ON -DHAVE_LLVM_LIT=ON "-DLLVM_ENABLE_RUNTIMES=libcxx;libcxxabi" -DLLVM_ENABLE_LLD=ON -DLLVM_USE_LINKER=lld -DLIBCXX_CXX_ABI=default -GNinja /var/lib/buildkite-agent/builds/buildkite-588bd64db9-m924d-1/mlir/mlir-core/llvm/runtimes/../../runtimes && /usr/bin/cmake -E touch /tmp/ci-jSvVzRPAaN/runtimes/runtimes-stamps//runtimes-configure


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115852/new/

https://reviews.llvm.org/D115852