[PATCH] D115204: Port __sanitizer::StopTheWorld to Windows

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.

In D115204#3200776 <https://reviews.llvm.org/D115204#3200776>, @clemenswasser wrote:

> In D115204#3200750 <https://reviews.llvm.org/D115204#3200750>, @vitalybuka wrote:
>
>> @clemenswasser Please upload fixed version here and we will try again
>
> What do you mean by fixed version? Did I forget to fix something?

Sorry, I you didn't reopen review, so I didn't check if there is any new revision.

@mstorsjo Would you like to try this version?



================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stoptheworld_win.cpp:105
+      const bool thread_already_suspended =
+          std::find(suspended_threads_list.threadIds.begin(),
+                    suspended_threads_list.threadIds.end(),
----------------
mstorsjo wrote:
> This is the one thing that fails to build when leaving out `<algorithm>`.
yep, we don't use STL in sanitizer runtimes


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115204/new/

https://reviews.llvm.org/D115204