[PATCH] D115950: [llvm-profgen] Use shared string table for function name to save memory usage

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/lib/MC/MCPseudoProbe.cpp:354
 
+    auto It = FuncNameStrings.insert(Name.str());
     // Initialize PseudoProbeFuncDesc and populate it into GUID2FuncDescMap
----------------
wenlei wrote:
> hoy wrote:
> > wenlei wrote:
> > > Just double checking, so the underlying data for probe section is freed after decoding? Where does that happen? 
> > The real name is on the disk. When read, a temp object `ErrorOrName` is created which is then freed.
> ErrorOrName doesn't own the underlying data. I was asking about the underlying data. The data is MCPseudoProbeDecoder::Data. Is OwningBinary taking care of the freeing?
Yes, the binary object owns that underlying data buffer, i.e, pointed by `const uint8_t *Start`. 



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115950/new/

https://reviews.llvm.org/D115950