[PATCH] D115775: [lld-macho] Handle $ld$hide[$os] symbols.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo marked an inline comment as done.
oontvoo added inline comments.


================
Comment at: lld/test/MachO/Inputs/libReexportSystem2.tbd:1
+--- !tapi-tbd-v3
+archs:            [ i386, x86_64 ]
----------------
This needs to be a standalone tbd because llvm-lit doesn't seem to understand tbd-v3 any more and I need the `re-exports: [filename]` for my test.


================
Comment at: lld/test/MachO/special-symbol-ld-hidden.s:12
+# RUN: llvm-objdump --macho --bind %t/ref-all.dylib | FileCheck %s --check-prefix=FOO
+
+# ERROR:  error: undefined symbol: _OBJC_CLASS_$_foo11
----------------
int3 wrote:
> should we check whether $ld$hide has an impact on re-exported symbols too?
Yes - good point. seemed to have no effect on reexported symbols. (I've checked with ld64)


================
Comment at: lld/test/MachO/special-symbol-ld-hidden.s:24-27
+.long	_xxx at GOTPCREL
+.long _OBJC_CLASS_$_foo11 at GOTPCREL
+.long _OBJC_CLASS_$_foo10 at GOTPCREL
+.long _OBJC_CLASS_$_bar at GOTPCREL
----------------
int3 wrote:
> shouldn't this be `.quad`? I believe `.long` is for 32-bit values
 it needed to be 32-bit because of the @GOTPCREL



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115775/new/

https://reviews.llvm.org/D115775