[PATCH] D115832: [DFAJumpThreading] Determinator BB should precede switch-defining BB

[Ehsan Amiri via Phabricator via llvm-commits]

amehsan accepted this revision.
amehsan added a comment.
This revision is now accepted and ready to land.

Alex and I have discussed this in detail. This testcase can also be investigated for potentially extending the algorithm. While we are confident that with the existing information (the paths that we gather during analysis phase) it is not possible to jump thread the switch statement, it may be possible to jump  thread it if we gather more information (gathering longer set of paths in the analysis phase). But at this point it does not seem worthwhile to explore this path, and the most reasonable solution is to add this new condition to make the case illegal. Alex have also compared with gcc, and they do not jump thread this switch statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115832/new/

https://reviews.llvm.org/D115832