[PATCH] D115941: [lld/tests] Stop setting the "asserts" and "debug" features

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 07:07:25 PST 2021


thakis created this revision.
thakis added a reviewer: MaskRay.
thakis requested review of this revision.

The last use of `REQUIRES: asserts` was removed in 2015 in 251b0e268 when the
old COFF linker was removed.

The last use of `REQUIRES: debug` was removed in 2013 in 72c5d3d7c in favor of
`REQUIRES: asserts`.

lld's test suite currently has no behavior difference with respect to
assertions or debug builds (and hasn't had it for 6 years). Let's keep it that
way :)


https://reviews.llvm.org/D115941

Files:
  lld/test/lit.cfg.py


Index: lld/test/lit.cfg.py
===================================================================
--- lld/test/lit.cfg.py
+++ lld/test/lit.cfg.py
@@ -63,9 +63,7 @@
     config.available_features.add('demangler')
 
 llvm_config.feature_config(
-    [('--build-mode', {'DEBUG': 'debug'}),
-     ('--assertion-mode', {'ON': 'asserts'}),
-     ('--targets-built', {'AArch64': 'aarch64',
+    [('--targets-built', {'AArch64': 'aarch64',
                           'AMDGPU': 'amdgpu',
                           'ARM': 'arm',
                           'AVR': 'avr',


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115941.395123.patch
Type: text/x-patch
Size: 558 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211217/fb0bab52/attachment.bin>


More information about the llvm-commits mailing list