[PATCH] D115927: [AA] Correctly maintain the sign of PartiaAlias offset

[Daniil Fukalov via Phabricator via llvm-commits]

dfukalov added inline comments.


================
Comment at: llvm/unittests/Analysis/AliasAnalysisTest.cpp:364-366
+  AR = AA.alias(Loc2, Loc1);
+  EXPECT_EQ(AR, AliasResult::PartialAlias);
+  EXPECT_EQ(-1, AR.getOffset());
----------------
dfukalov wrote:
> Thanks!
> Nit: I guess you can just extend the previous test "PartialAliasOffset" with this lines (and changed "-1" to "-4").
Sorry, I was wrong here - you indeed need separate test where `Loc1` is not GEP.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115927/new/

https://reviews.llvm.org/D115927