[PATCH] D113973: [LoopVectorize][CostModel] Choose smaller VFs for in-loop reductions with no loads/stores

Rosie Sumpter via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 06:46:46 PST 2021


RosieSumpter marked an inline comment as done.
RosieSumpter added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IVDescriptors.h:260
+  /// recurrence to the recurrence type.
+  const SmallPtrSet<Instruction *, 8> &getCastsToRecurrenceType() const {
+    return CastsToRecurrenceType;
----------------
fhahn wrote:
> this is only used to compute the minimum width, right? It seems like it would be simpler if we would compute the minimum width directly and store that, rather than a set of casts?
Hi @fhahn, thanks for the suggestion - that does seem to make more sense. Let me know if what I've done is what you had in mind.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113973/new/

https://reviews.llvm.org/D113973



More information about the llvm-commits mailing list