[PATCH] D115939: [SLP]Fix PR52756: SLPVectorizer crashes with assertion VecTy == FinalVecTy.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev created this revision.
ABataev added reviewers: fhahn, RKSimon, anton-afanasyev, dtemirbulatov.
Herald added a subscriber: hiraditya.
ABataev requested review of this revision.
Herald added a project: LLVM.

Need to check for the number of the unique non-constant values since the
unique values may include several constants.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115939

Files:
  llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
  llvm/test/Transforms/SLPVectorizer/X86/reused-undefs.ll


Index: llvm/test/Transforms/SLPVectorizer/X86/reused-undefs.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/SLPVectorizer/X86/reused-undefs.ll
@@ -0,0 +1,40 @@
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt -S -slp-vectorizer -mtriple=x86_64-unknown-linux-gnu -slp-threshold=-1000 < %s | FileCheck %s
+
+define i32 @main(i32 %0) {
+; CHECK-LABEL: @main(
+; CHECK-NEXT:  for.cond.preheader:
+; CHECK-NEXT:    br i1 false, label [[FOR_END:%.*]], label [[FOR_INC_PREHEADER:%.*]]
+; CHECK:       for.inc.preheader:
+; CHECK-NEXT:    [[TMP1:%.*]] = insertelement <8 x i32> <i32 0, i32 0, i32 0, i32 0, i32 0, i32 0, i32 poison, i32 poison>, i32 [[TMP0:%.*]], i32 6
+; CHECK-NEXT:    br i1 false, label [[FOR_END]], label [[L1_PREHEADER:%.*]]
+; CHECK:       for.end:
+; CHECK-NEXT:    [[DOTPR:%.*]] = phi i32 [ 0, [[FOR_INC_PREHEADER]] ], [ 0, [[FOR_COND_PREHEADER:%.*]] ]
+; CHECK-NEXT:    [[TMP2:%.*]] = insertelement <8 x i32> poison, i32 [[DOTPR]], i32 0
+; CHECK-NEXT:    [[SHUFFLE:%.*]] = shufflevector <8 x i32> [[TMP2]], <8 x i32> poison, <8 x i32> <i32 undef, i32 undef, i32 undef, i32 0, i32 0, i32 0, i32 0, i32 0>
+; CHECK-NEXT:    br label [[L1_PREHEADER]]
+; CHECK:       L1.preheader:
+; CHECK-NEXT:    [[TMP3:%.*]] = phi <8 x i32> [ [[SHUFFLE]], [[FOR_END]] ], [ [[TMP1]], [[FOR_INC_PREHEADER]] ]
+; CHECK-NEXT:    ret i32 0
+;
+for.cond.preheader:
+  br i1 false, label %for.end, label %for.inc.preheader
+
+for.inc.preheader:
+  br i1 false, label %for.end, label %L1.preheader
+
+for.end:
+  %.pr = phi i32 [ 0, %for.inc.preheader ], [ 0, %for.cond.preheader ]
+  br label %L1.preheader
+
+L1.preheader:
+  %1 = phi i32 [ %.pr, %for.end ], [ %0, %for.inc.preheader ]
+  %2 = phi i32 [ %.pr, %for.end ], [ 0, %for.inc.preheader ]
+  %3 = phi i32 [ %.pr, %for.end ], [ 0, %for.inc.preheader ]
+  %4 = phi i32 [ %.pr, %for.end ], [ undef, %for.inc.preheader ]
+  %j.2.ph1 = phi i32 [ %.pr, %for.end ], [ 0, %for.inc.preheader ]
+  %k.0.ph = phi i32 [ undef, %for.end ], [ 0, %for.inc.preheader ]
+  %o.1.ph = phi i32 [ undef, %for.end ], [ 0, %for.inc.preheader ]
+  %n.1.ph = phi i32 [ undef, %for.end ], [ 0, %for.inc.preheader ]
+  ret i32 0
+}
Index: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
===================================================================
--- llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
+++ llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
@@ -3567,8 +3567,11 @@
     } else {
       LLVM_DEBUG(dbgs() << "SLP: Shuffle for reused scalars.\n");
       if (NumUniqueScalarValues <= 1 ||
-          (NumUniqueScalarValues == 2 &&
-           any_of(UniqueValues, UndefValue::classof)) ||
+          (UniquePositions.size() == 1 && all_of(UniqueValues,
+                                                 [](Value *V) {
+                                                   return isa<UndefValue>(V) ||
+                                                          !isConstant(V);
+                                                 })) ||
           !llvm::isPowerOf2_32(NumUniqueScalarValues)) {
         LLVM_DEBUG(dbgs() << "SLP: Scalar used twice in bundle.\n");
         newTreeEntry(VL, None /*not vectorized*/, S, UserTreeIdx);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115939.395114.patch
Type: text/x-patch
Size: 3271 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211217/f04af9b7/attachment.bin>