[PATCH] D115885: [SDAG] remove FP-to-int cast attribute check in fold to FTRUNC

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 05:44:41 PST 2021


RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/ftrunc.ll:4
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+sse4.1  | FileCheck %s --check-prefixes=SSE,SSE41
 ; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx     | FileCheck %s --check-prefixes=AVX1
 
----------------
spatel wrote:
> RKSimon wrote:
> > Should we have i686 test coverage here ?
> Sure - are we looking for something particular or just add one i686 + avx RUN as a sanity check?
i686 + AVX would be fine


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115885/new/

https://reviews.llvm.org/D115885



More information about the llvm-commits mailing list