[PATCH] D115885: [SDAG] remove FP-to-int cast attribute check in fold to FTRUNC

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 17 05:12:59 PST 2021


spatel added inline comments.


================
Comment at: llvm/test/CodeGen/X86/ftrunc.ll:605
 attributes #0 = { nounwind "no-signed-zeros-fp-math"="true" }
 attributes #1 = { nounwind "no-signed-zeros-fp-math"="true" "strict-float-cast-overflow"="false" }
----------------
pengfei wrote:
> So we can remove the attributes and all tests used it?
Yes, there's no need to test an attribute that does not exist. :)
That should make the diffs a little easier to follow. I could also pre-commit new tests with intrinsics and then delete the old tests if that seems better.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115885/new/

https://reviews.llvm.org/D115885



More information about the llvm-commits mailing list