[PATCH] D115533: [docs] [tools] Document and alphabetize all llvm-config command-line options

Fri Dec 17 00:43:21 PST 2021

jhenderson added inline comments.

================
Comment at: llvm/docs/CommandGuide/llvm-config.rst:46

- Print the source root from which LLVM was built.
+ Print the build system used to build LLVM (e.g. `cmake` or `gn`).

----------------
fw-immunant wrote:
> fw-immunant wrote:
> > jhenderson wrote:
> > > I'd actually get rid of "gn" to avoid confusion, as I believe gn builds aren't officially supported by core LLVM (it's maintained by the users of gn, rather than the wider community), like bazel, but I don't mind that much.
> > There seems to be code in the LLVM tree (in `llvm/utils/gn/secondary/llvm/tools/llvm-config/BUILD.gn`) that will result in `gn` appearing here, so I think it's reasonable to document the possibility. If you want it removed say so and I'll change it.
> Otherwise, go ahead and commit, as I don't have commit access myself.
Today's my last day in the office, before the Christmas break, so I don't want to be committing anything, in case I break things, as I won't necessarily have time to do the fix.

@andreadb/@GMNGeoffrey are either of you in a position to do so?

@fw-immunant, we'll need the name and email address you want this committed under, so that it appears in the git author details. Feel free to email directly, if preferred.

If nobody else gets to this, I'm happy to do it when I come back to work, although you could also try asking on llvm-dev for someone to take care of it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115533/new/

https://reviews.llvm.org/D115533