[PATCH] D113106: demangle xcoff label symbol for llvm-nm

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two minor suggestions remaining.



================
Comment at: llvm/test/tools/llvm-nm/XCOFF/demangle_sym_name.test:1
+## Test llvm-nm demangling of symbols for XCOFF object files.
+## Test following symbols:
----------------
Nit: follow existing practice in the other tests in llvm-nm, but I prefer `-` instead of `_` as separators, as they are easier to test, e.g. `demangle-sym-name.test`. Or you could just shorten it to `demangle.test`, since there's only one thing that is mangled (I assume?).


================
Comment at: llvm/tools/llvm-nm/llvm-nm.cpp:638-641
+  if (!Name.empty() && Name[0] == '.')
+    Name = Name.drop_front();
+  else
+    return demangle(Name);
----------------
I think I'd find this marginally easier to follow if it was flipped, and the else removed, as per the inline edit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113106/new/

https://reviews.llvm.org/D113106