[PATCH] D115918: [MS][NFC] Remove SEH chaininfo assembler macros

[namazso via Phabricator via llvm-commits]

namazso created this revision.
namazso added a project: LLVM.
Herald added a subscriber: hiraditya.
namazso requested review of this revision.
Herald added a subscriber: llvm-commits.

These macros cannot be used to generate valid output and it has been like that since their introduction 10 years ago.

Chaining is to be used for function chunks out of the main function's region, and RUNTIME_FUNCTION ranges should never intersect or overlap. The current implementation *only* allows such use that the generated output contains overlapping ones, which is invalid (and also ignored by windows). Additionally, the current syntax is not suitable for implementing any correct behavior, as the chained function chunk should refer to the info or function it chains to, which is not done in the current syntax. A search on search engines and github show that this macro wasn't used outside of LLVM (which is understandable as it never worked) so I think this warrants the NFC tag.

The tests also exhibit the incorrect behavior, and pass since the offsets are regexed out so overlapping ranges don't fail.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D115918

Files:
  llvm/include/llvm/MC/MCStreamer.h
  llvm/lib/MC/MCAsmStreamer.cpp
  llvm/lib/MC/MCParser/COFFAsmParser.cpp
  llvm/lib/MC/MCStreamer.cpp
  llvm/test/MC/AsmParser/directive_seh.s
  llvm/test/MC/COFF/seh.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115918.395053.patch
Type: text/x-patch
Size: 8677 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211217/9e24a3c7/attachment.bin>