[compiler-rt] fcfcc64 - [compiler-rt][NFC] add note to interface_symbols_linux.cpp about darwin

Emily Shi via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 16 13:08:08 PST 2021


Author: Emily Shi
Date: 2021-12-16T13:08:03-08:00
New Revision: fcfcc64ce921abab0730b7c0a7b7f628a205cde4

URL: https://github.com/llvm/llvm-project/commit/fcfcc64ce921abab0730b7c0a7b7f628a205cde4
DIFF: https://github.com/llvm/llvm-project/commit/fcfcc64ce921abab0730b7c0a7b7f628a205cde4.diff

LOG: [compiler-rt][NFC] add note to interface_symbols_linux.cpp about darwin

There were changes made to the linux version of this test that were not made for darwin
(see https://reviews.llvm.org/D115837) and this caused downstream failures.

Adding comment to this test to remind people to edit interface_symbols_darwin.cpp.
There is the reverse of this comment in the darwin file to remind us to edit the linux version already.

Differential Revision: https://reviews.llvm.org/D115899

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.cpp b/compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.cpp
index 37bca5852f49a..a1579a541ed7e 100644
--- a/compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/interface_symbols_linux.cpp
@@ -1,4 +1,6 @@
 // Check the presence of interface symbols in compiled file.
+// If you're changing this file, please also change
+// ../Darwin/interface_symbols_darwin.cpp
 
 // RUN: %clangxx -x c++-header -o - -E %p/../../../../lib/asan/asan_interface.inc  \
 // RUN:  | sed "s/INTERFACE_FUNCTION/\nINTERFACE_FUNCTION/g" >  %t.asan_interface.inc


        


More information about the llvm-commits mailing list