[PATCH] D113086: [flang] Add a semantics test for co_reduce

Katherine Rasmussen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 16 12:04:18 PST 2021


ktras added inline comments.


================
Comment at: flang/test/Semantics/collectives05.f90:4
+! Check for semantic errors in co_reduce() subroutine calls
+! To Do: add co_reduce to the evaluation stage
+module test_co_reduce
----------------
clementval wrote:
> What is the evaluation stage?
@rouson added this comment because I plan to add the collective subroutines to the list of intrinsic functions in `flang/lib/Evaluate/intrinsics.cpp`. If the term evaluation stage does not have significant meaning, I will suggest to Damian to change the to-do comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113086/new/

https://reviews.llvm.org/D113086



More information about the llvm-commits mailing list