[PATCH] D115325: [DWARF] Fix PR51087 Extraneous enum record in DWARF with type units

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1394
+  CU.getOrCreateTypeDIE(&Ty);
+};
+
----------------
Drop the extra semicolon here


================
Comment at: llvm/test/DebugInfo/X86/type-units-used-enum.mir:1
+# RUN: %llc_dwarf %s -generate-type-units -o - -filetype=obj \
+# RUN: | llvm-dwarfdump -o - - \
----------------
I think we'd usually test this with LLVM IR, rather than mir - bit simpler in some ways, at least? (similar feedback on the other tests)
Maybe could test all 3 cases in one test without it being too complicated? (process creation overhead can be significant on some platforms (Windows) so we tend away from making tests /too/ fine grained... which is pretty subjective, admittedly)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115325/new/

https://reviews.llvm.org/D115325