[PATCH] D115559: AMDGPU: Propagate amdgpu-waves-per-eu with attributor

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUAttributor.cpp:680
+    ConstantRange Range(APInt(32, Min), APInt(32, Max + 1));
+    intersectKnown(Range);
+  }
----------------
jdoerfert wrote:
> Somewhat surprising you intersect the known range with an assumed result, if that is on purpose probably worth a comment explaining why this is reasonable.
I'm confused by your surprise. This is the initialize, so the assumed state doesn't mean anything? All the other IntegerRangeState attributes start out with intersectKnown in initialize()


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115559/new/

https://reviews.llvm.org/D115559