[PATCH] D115519: [llvm][docs] Describe how to work with patch series on Phabricator

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/docs/Phabricator.rst:182
+* If you want a single review to have multiple parent reviews then
+  add more with "and". For example: "Depends on D12344 and D12345".
+* Upload the commit with the web interface or `arc`
----------------
I think this should be a comma, as per my previous suggestion, rather than making "For example" a new sentence. It doesn't read right otherwise.


================
Comment at: llvm/docs/Phabricator.rst:195
+rebasing. These steps assume that you have a series of commits that you have
+not posted for review and use will use `arc` to upload them. They can be
+adapted if you're using the web interface or updating existing reviews.
----------------



================
Comment at: llvm/docs/Phabricator.rst:198-200
+One frequently used workflow for creating a series of patches using patch summaries
+is based on git's rebasing. These steps assume that you have a series of commits that
+you have not posted for review, but can be adapted to update existing reviews.
----------------
Looks like a duplicate paragraph?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115519/new/

https://reviews.llvm.org/D115519