[PATCH] D113973: [LoopVectorize][CostModel] Choose smaller VFs for in-loop reductions with no loads/stores

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/Analysis/IVDescriptors.h:279
+                                SmallPtrSetImpl<Instruction *> &Casts,
+                                bool IgnoreCasts);
+
----------------
Passing `IgnoreCasts` to `collectCastInstrs` seems a bit contradictory :)

Would it make more sense to pass two SmallPtrSet's, one named `CastsToRecurrenceType`  (for case `RecurrenceType == Cast->getDstTy()`) and the other `CastsFromRecurrenceType` (for case `RecurrenceType == Cast->getSrcTy()`) and making these two sets available in RecurrenceDescriptor under their respective names. Then either set can be queried depending on what information is needed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113973/new/

https://reviews.llvm.org/D113973