foad added a comment. As discussed offline, maybe split this patch into two? 1. Just the generic change to RegBankSelect 2. Add the AMDGPU combine CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113784/new/ https://reviews.llvm.org/D113784