[PATCH] D115519: [llvm][docs] Describe how to work with patch series on Phabricator

[Andrzej Warzynski via Phabricator via llvm-commits]

awarzynski added a comment.

It looks like after a few rounds of updates, two methods emerged:

- "Using the web UI"
- "Through commit messages/summaries"

Perhaps it's worth revisiting the idea of adding section titles? I think that it would help with the flow.



================
Comment at: llvm/docs/Phabricator.rst:181
+
+When you finally push the series to Github, please remove the "Depends on"
+lines from the commit messages. Since they add noise and duplicate git's
----------------
jhenderson wrote:
> Canonical spelling is "GitHub" (upper-case H).
I think that "pushing to GitHub" is too vague. Also, this might suggest that you normally push multiple patches at once. But often you push one patch at a time, right?


================
Comment at: llvm/docs/Phabricator.rst:185
+
+One frequently used workflow for this uses git's rebasing. These steps assume
+that you have a series of commits that you have not posted for review and use
----------------
It's not immediately clear what "this" refers to here. I would expand.


================
Comment at: llvm/docs/Phabricator.rst:187-188
+that you have a series of commits that you have not posted for review and use
+`arc` to upload them. They can be adapted if you're using the web interface,
+or updating existing reviews.
+
----------------
I would remove this last sentence. In this case, IMHO, less is more.

Basically, this is a bit complex and I think that focusing on `arc diff` + `git rebase` is sufficient. Yes, you can use the web UI too, but perhaps that's something that people can deduct here themselves?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115519/new/

https://reviews.llvm.org/D115519