[PATCH] D115009: [SPIRV 1/n] Add stub for SPIRV backend

[Renato Golin via Phabricator via llvm-commits]

rengolin added a comment.

Hi, I only saw that now.

In addition to adding the rest of the reviews as a child to this one, can you also please number them accordingly?

Please use 1/10, 2/10, etc. instead of 1/n, 2/n. It makes no sense to have a '/n'.

Also, make sure that the last patch allows the target to do something substantial (with tests), for example, parse/lower assembly instructions, lower a simple function with return, etc.

Once the first series is complete, you don't need to number the patches any more. That's the whole point of the '/n', to separate the before, where nothing works, with the after, where things progressively work better.

Finally, just a reminder that you should not merge any patch in the initial series until *all* patches in the series have been approved. This is crucial to avoid reverting patches on a half-implemented back-end.

Thanks!
Renato


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115009/new/

https://reviews.llvm.org/D115009