[PATCH] D115509: [FuncSpec] Respect MaxConstantsThreshold

Thu Dec 16 01:23:14 PST 2021

SjoerdMeijer added a comment.

In D115509#3195111 <https://reviews.llvm.org/D115509#3195111>, @snehasish wrote:

> lgtm.
>
> FYI in case you were not aware - if you have a dependent patch you can "Edit Related Revision > Edit Parent Revision" to ensure that the CI picks up the parent patch.

Ok, thanks! Also for the reviews of this patch and the other.

Just to let you know my plans in case you're interested. I am going to pick this up further and will be working on function specialisation some more. I am going to add some more tests, will work on some of the limitations, look at compile times which are actually good when it triggers but it's a bit too high when it doesn't, and start looking in supporting this with ThinLTO. So yes, to be continued. :-)

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115509/new/

https://reviews.llvm.org/D115509