[llvm] ebf65d4 - [Verifier] Make error message precise about which variable is being diagnosed.

[Yuanfang Chen via llvm-commits]

Author: Yuanfang Chen
Date: 2021-12-15T16:05:31-08:00
New Revision: ebf65d48420c7b6a9a15fde856f916882aec914c

URL: https://github.com/llvm/llvm-project/commit/ebf65d48420c7b6a9a15fde856f916882aec914c
DIFF: https://github.com/llvm/llvm-project/commit/ebf65d48420c7b6a9a15fde856f916882aec914c.diff

LOG: [Verifier] Make error message precise about which variable is being diagnosed.

NFCI.

Added: 
    

Modified: 
    llvm/lib/IR/Verifier.cpp
    llvm/test/Verifier/llvm.used-invalid-init2.ll

Removed: 
    


################################################################################
diff  --git a/llvm/lib/IR/Verifier.cpp b/llvm/lib/IR/Verifier.cpp
index 4cb18fc3ed946..1dbac8cc40ada 100644
--- a/llvm/lib/IR/Verifier.cpp
+++ b/llvm/lib/IR/Verifier.cpp
@@ -735,8 +735,9 @@ void Verifier::visitGlobalVariable(const GlobalVariable &GV) {
           Value *V = Op->stripPointerCasts();
           Assert(isa<GlobalVariable>(V) || isa<Function>(V) ||
                      isa<GlobalAlias>(V),
-                 "invalid llvm.used member", V);
-          Assert(V->hasName(), "members of llvm.used must be named", V);
+                 Twine("invalid ") + GV.getName() + " member", V);
+          Assert(V->hasName(),
+                 Twine("members of ") + GV.getName() + " must be named", V);
         }
       }
     }

diff  --git a/llvm/test/Verifier/llvm.used-invalid-init2.ll b/llvm/test/Verifier/llvm.used-invalid-init2.ll
index ee8a970bf107d..bbc2c1ba97416 100644
--- a/llvm/test/Verifier/llvm.used-invalid-init2.ll
+++ b/llvm/test/Verifier/llvm.used-invalid-init2.ll
@@ -2,6 +2,10 @@
 
 @a = global i8 42
 @llvm.used = appending global [2 x i8*] [i8* @a, i8* null], section "llvm.metadata"
+ at llvm.compiler.used = appending global [2 x i8*] [i8* @a, i8* null], section "llvm.metadata"
 
 ; CHECK: invalid llvm.used member
 ; CHECK-NEXT: i8* null
+
+; CHECK: invalid llvm.compiler.used member
+; CHECK-NEXT: i8* null