[PATCH] D115833: [gn build] Remove unhelpful default for goma_dir

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: aeubanks.
thakis requested review of this revision.
Herald added a project: LLVM.

The default hasn't worked in over 9 months now.

Getting a friendly error message if this isn't set is more useful than getting a bad default value.


https://reviews.llvm.org/D115833

Files:
  llvm/utils/gn/build/toolchain/BUILD.gn


Index: llvm/utils/gn/build/toolchain/BUILD.gn
===================================================================
--- llvm/utils/gn/build/toolchain/BUILD.gn
+++ llvm/utils/gn/build/toolchain/BUILD.gn
@@ -3,15 +3,11 @@
 declare_args() {
   # If is_goma is true, the location of the goma client install.
   # Set this to the output of `goma_ctl goma_dir`.
-  if (host_os == "win") {
-    goma_dir = "C:/src/goma/goma-win64"
-  } else {
-    goma_dir = getenv("HOME") + "/goma"
-  }
+  goma_dir = ""
 }
 
 assert(!use_goma || goma_dir != "",
-       "set goma_dir to the output of `goma_ctl goma_dir` in your args.gn")
+       "set `goma_dir` to the output of `goma_ctl goma_dir` in your args.gn")
 
 template("unix_toolchain") {
   toolchain(target_name) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D115833.394670.patch
Type: text/x-patch
Size: 755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20211215/276ae777/attachment.bin>