[PATCH] D115486: [lit] Support relative path arguments

Geoffrey Martin-Noble via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 15 14:35:20 PST 2021


GMNGeoffrey added inline comments.


================
Comment at: llvm/utils/lit/lit/cl_arguments.py:240-243
+    # Convert path arguments to absolute paths, so they can be referenced
+    # anywhere.
+    opts.path = [os.path.abspath(p) for p in opts.path]
+
----------------
yln wrote:
> Could we replace this block by specifying `type=os.path.abspath` as the "converter" function where the `--path` argument is declared?
Indeed we can, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115486/new/

https://reviews.llvm.org/D115486



More information about the llvm-commits mailing list