[PATCH] D113741: [RFC][DwarfDebug][AsmPrinter] Support emitting function-local declaration for a lexical block

Wed Dec 15 13:59:41 PST 2021

dblaikie added a comment.

In D113741#3195668 <https://reviews.llvm.org/D113741#3195668>, @krisb wrote:

> In D113741#3190810 <https://reviews.llvm.org/D113741#3190810>, @dblaikie wrote:
>
>> In D113741#3190544 <https://reviews.llvm.org/D113741#3190544>, @dblaikie wrote:
>>
>>> FWIW this also caused some ThinLTO build failures (linker errors specifically) along the lines of:
>>>
>>>   (.debug_gnu_pubnames): name lookup table at offset 0x9a5 has a terminator at offset 0x9b3 before the expected end at 0x9f2
>>>
>>> I don't have a simple/small reproduction at the moment. But would be good to work together/reach out to me if it's not easily discoverable and figure out this issue before recommitting.
>>
>> Oh, I misread - that this issue was seen on the recommit & hasn't ben reverted yet.
>>
>> I'll try to reduce a test case, but might be worth reverting in the interim regardless?
>
> If you think it'd be better to revert until the issue gets resolved then okay, let me know and I'll revert it. I can't say more without a reproducer.
> But could you please share a way to reproduce the issue? Not small/simple is also okay.

Unfortunately due to ThinLTO it's a bit hard for me to extract (& not sure if there are bits I need to anonymize, etc - which is easier when reducing just a single file) and share at the moment :/

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113741/new/

https://reviews.llvm.org/D113741