[PATCH] D115486: [lit] Support relative path arguments

[Julian Lettner via Phabricator via llvm-commits]

yln accepted this revision.
yln added a comment.
This revision is now accepted and ready to land.

I haven't been in a situation where I had to (manually) use this option, but your explanation sounds sensible to me.

LGTM with 1 optional nit!



================
Comment at: llvm/utils/lit/lit/cl_arguments.py:240-243
+    # Convert path arguments to absolute paths, so they can be referenced
+    # anywhere.
+    opts.path = [os.path.abspath(p) for p in opts.path]
+
----------------
Could we replace this block by specifying `type=os.path.abspath` as the "converter" function where the `--path` argument is declared?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115486/new/

https://reviews.llvm.org/D115486