[PATCH] D109917: [InstCombine] Improve TryToSink for side-effecting calls that would be trivially dead

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 15 13:39:43 PST 2021


reames added a comment.

I posted D115829 <https://reviews.llvm.org/D115829> to separate out the writeonly argument logic.  This isn't a direct split as the logic isn't in the same utility function, but it gets the key bit of logic in and exercised.  I tried doing a straight split first, and that caused a few more test diffs than I expected as we have a number of places using wouldBeTriviallyDead as utilities.  We'll probably sink this down afterwards, but I wanted to minimize the code impact in the first patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109917/new/

https://reviews.llvm.org/D109917



More information about the llvm-commits mailing list