[PATCH] D115825: Re-apply "Only define LLVM_EXTERNAL_VISIBILITY when building libLLVM dylib"

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: mlir/include/mlir/Support/TypeID.h:118
 /// available within LLVM.
-struct LLVM_EXTERNAL_VISIBILITY TypeIDExported {
+struct MLIR_CAPI_EXPORTED TypeIDExported {
   template <typename T>
----------------
mehdi_amini wrote:
> benlangmuir wrote:
> > I'm not sure if matching the CAPI visibility is precisely what you want here, but it seems like a strict improvement over matching the LLVM visibility, which should be mostly orthogonal from what you do here.
> Not really: if you look into `mlir/tools/mlir-shlib/CMakeLists.txt` we're creating libMLIR.dylib hand-in-hand with libLLVM.dylib ; this is what this mechanism is covering here.
> 
> (I need to go back to the original revision, I haven't followed exactly what the change is so far)
https://reviews.llvm.org/D113610 for the record


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115825/new/

https://reviews.llvm.org/D115825