[PATCH] D115775: [lld-macho] Handle $ld$hide[$os] symbols.

[Keith Smiley via Phabricator via llvm-commits]

keith added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:1158
+
+                if (exportingFile->hiddenSymbols.contains(
+                        CachedHashStringRef(savedName)))
----------------
nit: looks like this could go above the bool assignments


================
Comment at: lld/MachO/InputFiles.cpp:1388
+    }
+    shouldHide = versionTup == config->platformInfo.minimum;
+  } else
----------------
is == there right comparison here? not entirely sure of the use cases but should a .1 difference still have this logic apply?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115775/new/

https://reviews.llvm.org/D115775