[PATCH] D115418: [dwarf][NFC] Move expandBundle() to MachO.h

[Greg Clayton via Phabricator via llvm-commits]

clayborg accepted this revision.
clayborg added a comment.

LGTM!



================
Comment at: llvm/lib/Object/MachOObjectFile.cpp:4727
+MachOObjectFile::findDsymObjectMembers(StringRef Path) {
+  SmallString<256> BundlePath(Path);
+  // Normalize input path. This is necessary to accept `bundle.dSYM/`.
----------------
That second error looks great. You might want to see what the error looks like if you have a ".dSYM" directory but with no paths inside of it. The directory iterator will return an error if any of the "Contents", "Resources" or "DWARF do not exist and that error might be a bit cryptic. 

So a few extra things to try just to make sure errors are not too bad:
- no user permissions for a valid dSYM bundle
- missing directories inside a dSYM bundle ("Contents", "Resources", "DWARF")



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115418/new/

https://reviews.llvm.org/D115418