[PATCH] D112758: [llvm] [Debuginfo] Debuginfod client library.

[Ethan Stewart via Phabricator via llvm-commits]

estewart08 added inline comments.


================
Comment at: llvm/unittests/Debuginfod/DebuginfodTests.cpp:34
+  OF.close();
+  Expected<std::string> PathOrErr = getCachedOrDownloadArtifact(
+      UniqueKey, /*UrlPath=*/"/null", CacheDir,
----------------
This eventually returns a path to $HOME via a call to cache_directory. I ran into some permission issues on a CI build. Is it safe to assume that $HOME is always writable?

Should this test set XDG_CACHE_HOME instead?
```
setenv("XDG_CACHE_HOME", "/tmp", /*replace=*/1);
```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112758/new/

https://reviews.llvm.org/D112758