[PATCH] D115616: [Debugify][OriginalDIMode] Make HTML reporting infrastructure more resilient

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/utils/llvm-original-di-preservation.py:381
 
-  debug_info_bugs = get_json(opts.file_name)
+  skipped_lines = 0
+  (debug_info_bugs, skipped_lines) = get_json(opts.file_name)
----------------
Nit, this declaration of skipped_lines looks unnecessary


================
Comment at: llvm/utils/llvm-original-di-preservation.py:409
     for bug in bugs:
-      bugs_metadata = bug["metadata"]
+      try:
+        bugs_metadata = bug["metadata"]
----------------
Maybe for this section we could also use a `skipped_bugs` counter, so that we can still see there are file errors when the individual bugs are incorrect, even if every line is still a valid json object with all the expected top level fields present?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115616/new/

https://reviews.llvm.org/D115616