[PATCH] D115205: [CSSPGO] Use nested context-sensitive profile.

Wed Dec 15 00:34:34 PST 2021

uabelho added a comment.

Hi,

Is anyone else having problems with this commit?
We get:

  /proj/flexasic/app/llvm/8.0/bin/clang++  -march=corei7  -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/ProfileData -I../lib/ProfileData -Iinclude -I../include -fPIC -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wstring-conversion -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG    -fno-exceptions -fno-rtti -UNDEBUG -std=c++14 -MD -MT lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProf.cpp.o -MF lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProf.cpp.o.d -o lib/ProfileData/CMakeFiles/LLVMProfileData.dir/SampleProf.cpp.o -c ../lib/ProfileData/SampleProf.cpp
  In file included from ../lib/ProfileData/SampleProf.cpp:14:
  In file included from ../include/llvm/ProfileData/SampleProf.h:17:
  In file included from ../include/llvm/ADT/DenseSet.h:16:
  In file included from ../include/llvm/ADT/DenseMap.h:16:
  In file included from ../include/llvm/ADT/DenseMapInfo.h:19:
  In file included from /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/tuple:39:
  In file included from /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/array:38:
  In file included from /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/stdexcept:39:
  In file included from /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/string:41:
  In file included from /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/allocator.h:46:
  In file included from /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/x86_64-unknown-linux-gnu/bits/c++allocator.h:33:
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/ext/new_allocator.h:120:23: error: no matching constructor for initialization of 'std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples>'
          { ::new((void *)__p) _Up(std::forward<_Args>(__args)...); }
                               ^   ~~~~~~~~~~~~~~~~~~~~~~~~~~~
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/alloc_traits.h:530:8: note: in instantiation of function template specialization '__gnu_cxx::new_allocator<std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> > >::construct<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples>, llvm::StringRef, llvm::sampleprof::FunctionSamples &>' requested here
          { __a.construct(__p, std::forward<_Args>(__args)...); }
                ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_tree.h:529:23: note: in instantiation of function template specialization 'std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> > > >::construct<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples>, llvm::StringRef, llvm::sampleprof::FunctionSamples &>' requested here
                _Alloc_traits::construct(_M_get_Node_allocator(),
                               ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_tree.h:546:4: note: in instantiation of function template specialization 'std::_Rb_tree<std::__cxx11::basic_string<char>, std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples>, std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> >, std::less<void>, std::allocator<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> > >::_M_construct_node<llvm::StringRef, llvm::sampleprof::FunctionSamples &>' requested here
            _M_construct_node(__tmp, std::forward<_Args>(__args)...);
            ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_tree.h:2123:19: note: in instantiation of function template specialization 'std::_Rb_tree<std::__cxx11::basic_string<char>, std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples>, std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> >, std::less<void>, std::allocator<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> > >::_M_create_node<llvm::StringRef, llvm::sampleprof::FunctionSamples &>' requested here
          _Link_type __z = _M_create_node(std::forward<_Args>(__args)...);
                           ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_map.h:559:16: note: in instantiation of function template specialization 'std::_Rb_tree<std::__cxx11::basic_string<char>, std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples>, std::_Select1st<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> >, std::less<void>, std::allocator<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> > >::_M_emplace_unique<llvm::StringRef, llvm::sampleprof::FunctionSamples &>' requested here
          { return _M_t._M_emplace_unique(std::forward<_Args>(__args)...); }
                        ^
  ../lib/ProfileData/SampleProf.cpp:524:18: note: in instantiation of function template specialization 'std::map<std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples, std::less<void>, std::allocator<std::pair<const std::__cxx11::basic_string<char>, llvm::sampleprof::FunctionSamples> > >::emplace<llvm::StringRef, llvm::sampleprof::FunctionSamples &>' requested here
        SamplesMap.emplace(OrigChildContext.getName(), *ChildProfile);
                   ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:112:26: note: candidate constructor not viable: no known conversion from 'llvm::StringRef' to 'const const std::__cxx11::basic_string<char>' for 1st argument
        _GLIBCXX_CONSTEXPR pair(const _T1& __a, const _T2& __b)
                           ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:138:12: note: candidate constructor template not viable: no known conversion from 'llvm::StringRef' to 'const const std::__cxx11::basic_string<char>' for 1st argument
          constexpr pair(const _T1& __x, _U2&& __y)
                    ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:133:12: note: candidate template ignored: requirement 'is_convertible<llvm::StringRef, const std::__cxx11::basic_string<char> >::value' was not satisfied [with _U1 = llvm::StringRef]
          constexpr pair(_U1&& __x, const _T2& __y)
                    ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:144:12: note: candidate template ignored: requirement '__and_<std::is_convertible<llvm::StringRef, const std::__cxx11::basic_string<char> >, std::is_convertible<llvm::sampleprof::FunctionSamples &, llvm::sampleprof::FunctionSamples> >::value' was not satisfied [with _U1 = llvm::StringRef, _U2 = llvm::sampleprof::FunctionSamples &]
          constexpr pair(_U1&& __x, _U2&& __y)
                    ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:124:12: note: candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided
          constexpr pair(const pair<_U1, _U2>& __p)
                    ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:150:12: note: candidate constructor template not viable: requires single argument '__p', but 2 arguments were provided
          constexpr pair(pair<_U1, _U2>&& __p)
                    ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:155:9: note: candidate constructor template not viable: requires 3 arguments, but 2 were provided
          pair(piecewise_construct_t, tuple<_Args1...>, tuple<_Args2...>);
          ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:206:9: note: candidate constructor template not viable: requires 4 arguments, but 2 were provided
          pair(tuple<_Args1...>&, tuple<_Args2...>&,
          ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:127:17: note: candidate constructor not viable: requires 1 argument, but 2 were provided
        constexpr pair(const pair&) = default;
                  ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:128:17: note: candidate constructor not viable: requires 1 argument, but 2 were provided
        constexpr pair(pair&&) = default;
                  ^
  /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/stl_pair.h:108:26: note: candidate constructor not viable: requires 0 arguments, but 2 were provided
        _GLIBCXX_CONSTEXPR pair()
                           ^
  1 error generated.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115205/new/

https://reviews.llvm.org/D115205