[PATCH] D115327: [WebAssembly] Fix reftype load/store match with idx from call
Paulo Matos via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 14 23:42:03 PST 2021
pmatos added inline comments.
================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1492
Idx = Base->getOperand(1);
- if (!Idx || GA->getNumValues() != 1 || Idx->getNumValues() != 1)
+ if (Idx.isUndef() || GA->getNumValues() != 1)
return false;
----------------
tlively wrote:
> Does the test in this revision cover this `Idx.isUndef()` case? I would have expected to see an `undef` in the IR.
Yes, good point. I should write a test covering this case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115327/new/
https://reviews.llvm.org/D115327
More information about the llvm-commits
mailing list